Fix: Upstream Bug Fixes for Lycoris - #130
Open
ash-bluepollution95 wants to merge 1 commit into
Open
Conversation
…ixed by Claude and I May 5 2026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LyCORIS fixes → contribute to https://github.com/67372a/LyCORIS
7.
lycoris/modules/full.py—None.dtypeAttributeErrorFile:
lycoris/modules/full.pyline 235diff_bis initialized toNoneon line 230. The dtype guard at line 235compared
org_bias.dtype != diff_b.dtypebeforediff_bwas assigned a tensorvalue — guaranteed
AttributeErroron every call toget_diff_weightwhenself.bias is not None.Fix: Compare against
self.bias.dtype(the correct reference) instead ofthe not-yet-assigned
diff_b.dtype.8.
test/regex_args.py— wrong preset key names in test fixtureFile:
test/regex_args.pyline 40–41reset_globals()passed"reg_dims"and"reg_lrs"toapply_preset(), butthe validated key names are
"network_reg_dims"and"network_reg_lrs". Everytest that calls this fixture in cleanup raises
KeyError, breaking the entiretest file.
Fix:
"reg_dims"→"network_reg_dims","reg_lrs"→ `"network_reg_lrsNote: There may be more bugs that you'd noted in your readme, and I haven't QUITE had a chance to test these fixes yet, feel free to "Yeet" or deny, i just figured since CR picked them up when I was updating vendored code i'd contribute back. I have more fixes for SD-scripts coming in a minute, just that i had to open up the markdown in notepad++ to find the details