Skip to content

Fix: Upstream Bug Fixes for Lycoris - #130

Open
ash-bluepollution95 wants to merge 1 commit into
67372a:devfrom
UselessToys:dev
Open

Fix: Upstream Bug Fixes for Lycoris#130
ash-bluepollution95 wants to merge 1 commit into
67372a:devfrom
UselessToys:dev

Conversation

@ash-bluepollution95

Copy link
Copy Markdown

LyCORIS fixes → contribute to https://github.com/67372a/LyCORIS

7. lycoris/modules/full.pyNone.dtype AttributeError

File: lycoris/modules/full.py line 235

diff_b is initialized to None on line 230. The dtype guard at line 235
compared org_bias.dtype != diff_b.dtype before diff_b was assigned a tensor
value — guaranteed AttributeError on every call to get_diff_weight when
self.bias is not None.

Fix: Compare against self.bias.dtype (the correct reference) instead of
the not-yet-assigned diff_b.dtype.


8. test/regex_args.py — wrong preset key names in test fixture

File: test/regex_args.py line 40–41

reset_globals() passed "reg_dims" and "reg_lrs" to apply_preset(), but
the validated key names are "network_reg_dims" and "network_reg_lrs". Every
test that calls this fixture in cleanup raises KeyError, breaking the entire
test file.

Fix: "reg_dims""network_reg_dims", "reg_lrs" → `"network_reg_lrs

Note: There may be more bugs that you'd noted in your readme, and I haven't QUITE had a chance to test these fixes yet, feel free to "Yeet" or deny, i just figured since CR picked them up when I was updating vendored code i'd contribute back. I have more fixes for SD-scripts coming in a minute, just that i had to open up the markdown in notepad++ to find the details

@67372a 67372a self-assigned this May 9, 2026
@67372a 67372a added the bug Something isn't working label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants