Skip to content

feat: pivot complete-unit-tests workflow to multi-phase coverage iteration#913

Merged
7474 merged 4 commits intomasterfrom
copilot/improve-test-coverage-iteration
Apr 4, 2026
Merged

feat: pivot complete-unit-tests workflow to multi-phase coverage iteration#913
7474 merged 4 commits intomasterfrom
copilot/improve-test-coverage-iteration

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

CmdDatas/Commands tests are effectively complete (4 remaining: ABGMCmd, AIfCmd, ATalkCmd, FontCmd). The Agentic Workflow needed to shift focus to the next uncovered areas: Commands/ (~8,700 src lines, ~11% tested) and Intermissions/ (2,200 lines, 0% tested).

Changes to complete-unit-tests.md

  • Description: Updated to describe a 3-phase coverage plan with no per-PR size limit — each run covers as much as possible
  • Agent intro: Renamed to "カバレッジ補強エージェント", added explicit phase priority and instruction to maximize tests per run
  • Step 1 (new): Phase detection logic — checks CmdDatas remaining → Commands/ gap → Intermissions/ gap in order
  • Step 2–3: Per-phase instructions; Step 3 includes a prioritized file list for Commands/ (smaller/simpler files first, Command.attack.cs / Command.process.cs last due to GUI coupling); all uncovered files targeted in a single run
  • Step 4: Phase 1 uses help docs as before; Phases 2–3 reference source code directly (no help files exist for these areas)
  • Step 5: New test class patterns for Commands/ partial-class tests and Intermissions/, including MockGUI handler setup
  • Step 6: Discrepancy policy adapted — source code is the spec for Phases 2–3, so only report ambiguity/untestable design issues
  • Step 8: PR title format includes phase number; body includes per-phase coverage summary

Coverage gaps being targeted

Area Source lines Test lines Coverage
CmdDatas/Commands/ 13,821 13,287 ✅ ~done
Commands/ 8,691 978 ⚠️ ~11%
Intermissions/ 2,204 0 ❌ 0%

Copilot AI and others added 2 commits April 3, 2026 20:05
…teration

CmdDatas/Commands tests are nearly complete (4 remaining).
Update the workflow to support iterating through:
- Phase 1: Finish remaining CmdDatas commands (ABGMCmd, AIfCmd, ATalkCmd, FontCmd)
- Phase 2: Expand Commands/ coverage (8700 src lines, ~11% tested)
- Phase 3: Add Intermissions/ tests (2200 lines, 0% tested)

Each step now detects the current phase and provides appropriate
test patterns, source references, and file placement guidance.

Agent-Logs-Url: https://github.com/7474/SRC/sessions/b0a62599-173f-4e91-a6a8-22f475c567a3

Co-authored-by: 7474 <4744735+7474@users.noreply.github.com>
@7474
Copy link
Copy Markdown
Owner

7474 commented Apr 3, 2026

@copilot 1PRのサイズ制限を外して、1回の反復での対応量を重視するように見直してください。

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 3, 2026

@copilot 1PRのサイズ制限を外して、1回の反復での対応量を重視するように見直してください。

6129feb にて対応しました。PR サイズ制限(1000行)を全箇所から削除し、「1回の実行でできるだけ多くのテストを追加する」方針に変更しました。

Copilot AI requested a review from 7474 April 3, 2026 20:11
Copilot finished work on behalf of 7474 April 3, 2026 20:11
@7474 7474 marked this pull request as ready for review April 4, 2026 05:23
@7474 7474 merged commit bbf4ef9 into master Apr 4, 2026
3 checks passed
@7474 7474 deleted the copilot/improve-test-coverage-iteration branch April 4, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants