Skip to content

fix: span link when user types any text near the link #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IvanIhnatsiuk merged 2 commits into from
Feb 27, 2026
Merged

fix: span link when user types any text near the link #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02a798d
fix: span link when user types any text near the link
IvanIhnatsiuk Feb 27, 2026
9973973
fix: properly handle automatic links
IvanIhnatsiuk Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions android/src/main/java/com/swmansion/enriched/parser/HtmlToSpannedConverter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import android.text.Editable
import android.text.Spannable
import android.text.SpannableStringBuilder
import android.text.Spanned
import android.util.Log
import androidx.core.graphics.toColorInt
import com.swmansion.enriched.EnrichedTextInputView
import com.swmansion.enriched.constants.HtmlTags
Expand Down Expand Up @@ -286,7 +285,7 @@ class HtmlToSpannedConverter(
val href = ctx.attributes?.getValue("", "href") ?: return

applyInline(ctx) {
EnrichedLinkSpan(href, mStyle)
EnrichedLinkSpan(href, mStyle, true)
}
return
}
Expand Down
33 changes: 31 additions & 2 deletions android/src/main/java/com/swmansion/enriched/styles/ParametrizedStyles.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ import com.swmansion.enriched.spans.EnrichedLinkSpan
import com.swmansion.enriched.spans.EnrichedMentionSpan
import com.swmansion.enriched.spans.EnrichedSpans
import com.swmansion.enriched.spans.TextStyle
import com.swmansion.enriched.spans.interfaces.EnrichedSpan
import com.swmansion.enriched.utils.getSafeSpanBoundaries
import com.swmansion.enriched.utils.removeZWS
import kotlin.math.max

class ParametrizedStyles(
private val view: EnrichedTextInputView,
Expand Down Expand Up @@ -172,6 +174,9 @@ class ParametrizedStyles(
if (isSettingLinkSpan || !canLinkBeApplied()) return

val spannable = view.text as? Spannable ?: return
// If user inserted a newline right after a link, don't touch spans.
if (isNewlineInsertedAtEndOfSpan(spannable, editStart, editEnd, EnrichedLinkSpan::class.java)) return

val affectedRange = getLinksAffectedRange(spannable, editStart, editEnd)
val contextText =
spannable
Expand Down Expand Up @@ -227,12 +232,15 @@ class ParametrizedStyles(

private fun afterTextChangedMentions(
s: CharSequence,
startCursorPosition: Int,
endCursorPosition: Int,
) {
val mentionHandler = view.mentionHandler ?: return
val currentWord = getWordAtIndex(s, endCursorPosition) ?: return

val spannable = view.text as Spannable
if (isNewlineInsertedAtEndOfSpan(spannable, startCursorPosition, endCursorPosition, EnrichedMentionSpan::class.java)) return

val currentWord = getWordAtIndex(s, endCursorPosition) ?: return
val indicatorsPattern = mentionIndicators.joinToString("|") { Regex.escape(it) }
val mentionIndicatorRegex = Regex("^($indicatorsPattern)")
val mentionRegex = Regex("^($indicatorsPattern)\\w*")
Expand Down Expand Up @@ -282,13 +290,34 @@ class ParametrizedStyles(
mentionHandler.onMention(indicator, text)
}

private fun <T : EnrichedSpan> isNewlineInsertedAtEndOfSpan(
spannable: Spannable,
editStart: Int,
editEnd: Int,
clazz: Class<T>,
): Boolean {
// insertion of exactly one char
if (editEnd != editStart + 1) return false
if (editStart < 0 || editStart >= spannable.length) return false

val insertedChar = spannable[editStart]
if (insertedChar != Strings.NEWLINE) return false

// If there is any span span whose END is exactly at editStart, then newline was inserted
// at the boundary right after the link -> do nothing.
val lookupStart = max(0, editStart - 1)
val spans = spannable.getSpans(lookupStart, editStart, clazz)

return spans.any { span -> spannable.getSpanEnd(span) == editStart }
}

fun afterTextChanged(
s: Editable,
startCursorPosition: Int,
endCursorPosition: Int,
) {
afterTextChangedLinks(startCursorPosition, endCursorPosition)
afterTextChangedMentions(s, startCursorPosition)
afterTextChangedMentions(s, startCursorPosition, endCursorPosition)
}

fun setImageSpan(
Expand Down