Open
Conversation
Why: It apparently isn't used anywhere in the parser.clj file but is used in the outfits.clj file What: Move the import to the outfits.clj file
Why: clj-kondo complains the shield damage and hull-damage are unused bindings. What: Comment them out so that they are still easily accessible if ever needed
Why: clj-kondo complains about ->map being referred but never used What: Remove it from the refer. If it is ever needed, it can easily be added back again
Why: It's used it in the file, to use the data binding, but not explicitly required. While it works, readability wise, I think it's better to be explicit What: Explicitly require endless-ships.parser
Why: An if missing an else branch can be surprising and when exists precisely to cover this use case What: Switch if to when
Why: rename-keys from clojure.set is apparently not used What: Remove the require
Why: Given clj-kondo doesn't complain about the rest of the Clojure codebase after the last few patches, this is the last hanging fruit. I 've been pondering over this for a while. Replacing (not (empty?) with idiom (seq) as per https://clojuredocs.org/clojure.core/empty_q feels a bit weird. It seems I am not the only one with this opinion per clj-kondo/clj-kondo#937 Given the above, I am inclined to just ignore it for now, but happy to be convinced otherwise What: Just instruct clj-kondo to ignore this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I am familiarizing myself more with the codebase, I can't help but see the various clj-kondo warnings. This is a series of commits that mostly appease clj-kondo. Note that I haven't touch the clojurescript part of the codebase at all, I am utterly unfamiliar with Clojurescript yet. If this is deemed OK and wanted, I can look also look into adding Github Action based linting on e.g. PRs