Skip to content

perf: optimize _parseMappings with charCodeAt #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7rulnik wants to merge 1 commit into
base: patch-0.6.1
Choose a base branch
from
Open

perf: optimize _parseMappings with charCodeAt #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/source-map-consumer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,35 +512,36 @@ BasicSourceMapConsumer.prototype._parseMappings =
var previousName = 0;
var length = aStr.length;
var index = 0;
var cachedSegments = {};
var temp = {};
var originalMappings = [];
var generatedMappings = [];
var mapping, str, segment, end, value;
var mapping, segment, end, value, charCode;

let subarrayStart = 0;
while (index < length) {
if (aStr.charAt(index) === ';') {
charCode = aStr.charCodeAt(index);
if (charCode === 59) { // ';'
generatedLine++;
index++;
previousGeneratedColumn = 0;

sortGenerated(generatedMappings, subarrayStart);
subarrayStart = generatedMappings.length;
}
else if (aStr.charAt(index) === ',') {
else if (charCode === 44) { // ','
index++;
}
else {
mapping = new Mapping();
mapping.generatedLine = generatedLine;

// Find end of segment (next ';' or ',')
for (end = index; end < length; end++) {
if (this._charIsMappingSeparator(aStr, end)) {
charCode = aStr.charCodeAt(end);
if (charCode === 44 || charCode === 59) { // ',' or ';'
break;
}
}
str = aStr.slice(index, end);

segment = [];
while (index < end) {
Expand Down