Skip building Ruby images that already exist#4
Closed
baelter wants to merge 5 commits into
Closed
Conversation
Checks if the image tag exists before building. New versions added to the matrix get built, existing ones are skipped. Manual workflow dispatch with force=true rebuilds everything.
There was a problem hiding this comment.
Pull request overview
This PR updates the Ruby container image GitHub Actions workflow to avoid rebuilding/pushing GHCR images when a given Ruby-version tag already exists, with an override to rebuild everything on manual dispatch.
Changes:
- Add a
workflow_dispatchboolean inputforceto rebuild all images on demand. - Add a pre-build step that checks GHCR for an existing tag via
docker buildx imagetools inspect. - Gate
docker/login-actionanddocker/build-push-actionbehind the “tag missing OR force” condition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
On PRs and pushes, only build versions that don't exist in GHCR yet. If the Dockerfile itself changed, rebuild all versions to validate (without pushing on PRs).
Comment on lines
+48
to
+52
| if [ "${{ github.event_name }}" = "pull_request" ]; then | ||
| BASE="${{ github.event.pull_request.base.sha }}" | ||
| else | ||
| BASE="${{ github.event.before }}" | ||
| fi |
Member
Author
|
Closing, we want to rebuild with latest upstream often to get security patches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recently changes so updates to the ruby version matrix would trigger builds. I then noticed all versions got rebuilt. I think this makes sense:
ruby/Dockerfilechanges (validated without pushing on PRs)forceinput to workflow_dispatch for manual full rebuildsBehavior