Skip to content

Update 8hobbies/workflows digest to 067ef9a #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renovate merged 1 commit into from
Feb 15, 2026
Merged

Update 8hobbies/workflows digest to 067ef9a #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
lint:
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@593ea3eb002451d046b787891d190896b45068e3
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 days ago

To fix the problem, explicitly declare the permissions for the GITHUB_TOKEN either at the workflow root (applies to all jobs) or on the lint job itself. For a standard lint workflow that only needs to read the repository to run checks, the least‑privilege baseline is contents: read. Since this workflow delegates to a reusable workflow and we cannot see its internals, we should still choose the minimal safe default of read‑only contents, which matches GitHub’s recommended starting point for many CI workflows.

The single best fix with minimal functional impact is to add a root‑level permissions block just below the on: section (or just above jobs:), specifying contents: read. This will apply to all jobs in this workflow, including lint, unless overridden. Concretely, in .github/workflows/lint.yml, add:

permissions:
  contents: read

between the on: block (lines 17–21) and the jobs: block (line 23). No imports or additional definitions are needed; this is purely a YAML configuration change within the workflow file.

Suggested changeset 1
.github/workflows/lint.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -20,6 +20,9 @@
   pull_request:
     branches: ["master"]
 
+permissions:
+  contents: read
+
 jobs:
   lint:
     uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5
EOF
@@ -20,6 +20,9 @@
pull_request:
branches: ["master"]

permissions:
contents: read

jobs:
lint:
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ jobs:
permissions:
pages: write
id-token: write
uses: 8hobbies/workflows/.github/workflows/npm-doc-pages.yml@593ea3eb002451d046b787891d190896b45068e3
uses: 8hobbies/workflows/.github/workflows/npm-doc-pages.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5
with:
doc-path: "docs/build"
2 changes: 1 addition & 1 deletion .github/workflows/publish-dry-run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
run:
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@593ea3eb002451d046b787891d190896b45068e3
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 days ago

To fix the problem, define an explicit permissions: block so that the GITHUB_TOKEN used by this workflow is restricted to the minimal required scopes. Since we cannot see the internals of 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml, the safest non-breaking change is to set permissions: read-all at the workflow level. This mirrors the typical read-only default while avoiding unintentionally revoking write permissions that the reusable workflow may rely on. If you later audit the reusable workflow and determine it needs less, you can replace read-all with a narrower set, e.g. contents: read or contents: read plus any specific write scopes needed.

Concretely, in .github/workflows/publish-dry-run.yml, add a root-level permissions: section between the on: block and the jobs: block. No imports or additional methods are needed; this is purely a YAML configuration change. For example, insert:

permissions:
  contents: read

if you know only read access to repository contents is needed, or:

permissions: read-all

as a conservative, generally safe least-privilege starting point compared with possible read-write defaults. This change preserves existing behavior of the reusable workflow while ensuring the workflow is no longer dependent on repository or organization defaults for GITHUB_TOKEN permissions.

Suggested changeset 1
.github/workflows/publish-dry-run.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/publish-dry-run.yml b/.github/workflows/publish-dry-run.yml
--- a/.github/workflows/publish-dry-run.yml
+++ b/.github/workflows/publish-dry-run.yml
@@ -20,6 +20,9 @@
   pull_request:
     branches: ["master"]
 
+permissions:
+  contents: read
+
 jobs:
   run:
     uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5
EOF
@@ -20,6 +20,9 @@
pull_request:
branches: ["master"]

permissions:
contents: read

jobs:
run:
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
tags: ["v*"]
jobs:
build:
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@593ea3eb002451d046b787891d190896b45068e3
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5
secrets:
npm-auth-token: ${{ secrets.NPM_TOKEN }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
test:
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@593ea3eb002451d046b787891d190896b45068e3
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 days ago

To fix the problem, explicitly limit the GITHUB_TOKEN permissions in this workflow to the minimum needed. Since we cannot see what operations are required by the reusable workflow, the safest generic baseline is read-only access to repository contents (contents: read). This documents the intended permissions and ensures the workflow remains least-privilege even if repository or organization defaults change later or the workflow is reused elsewhere.

The single best way to fix this without changing existing functionality is to add a permissions: block at the workflow root level (between on: and jobs:) so it applies to all jobs that do not override permissions. In .github/workflows/runtime.yml, insert:

permissions:
  contents: read

after the on: block (after line 21 in the provided snippet). This does not alter the job definition or the uses: reference and merely constrains what the GITHUB_TOKEN can do. No additional imports, methods, or definitions are required for a YAML workflow; GitHub Actions understands the permissions key natively.

Suggested changeset 1
.github/workflows/runtime.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/runtime.yml b/.github/workflows/runtime.yml
--- a/.github/workflows/runtime.yml
+++ b/.github/workflows/runtime.yml
@@ -20,6 +20,9 @@
   pull_request:
     branches: ["master"]
 
+permissions:
+  contents: read
+
 jobs:
   test:
     uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5
EOF
@@ -20,6 +20,9 @@
pull_request:
branches: ["master"]

permissions:
contents: read

jobs:
test:
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@067ef9a5f26017da21acc0f647d0f505951dcdf5
Copilot is powered by AI and may make mistakes. Always verify output.