fix change in return value of syscall.Open#103
Open
arturfabriciohahaedgy wants to merge 1 commit into9fans:mainfrom
Open
fix change in return value of syscall.Open#103arturfabriciohahaedgy wants to merge 1 commit into9fans:mainfrom
arturfabriciohahaedgy wants to merge 1 commit into9fans:mainfrom
Conversation
arturfabriciohahaedgy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run
go install 9fans.net/go/...@latestI recieved the following error:go/pkg/mod/9fans.net/go@v0.0.4/cmd/samterm/unix.go:62:21: cannot use fd (variable of type int) as type *os.File in argument to extprocIt appears that the value of
syscall.Openin the functionextstartingo/cmd/samterm/unix.go:43:12has changed from*os.Fileto an integer, and so breaking the parameter passed toextprocinsys.go.My commit fixes this by adding the
syscallimport to sys.go and using the functionsyscall.Read.