Support latest python and matplotlib versions#46
Open
PinkShnack wants to merge 8 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 67.27% 67.05% -0.22%
==========================================
Files 36 36
Lines 2793 2802 +9
==========================================
Hits 1879 1879
- Misses 914 923 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
All passing here: |
Contributor
Author
|
Code cov is failing but the rest can be reviewed @paulmueller |
paulmueller
requested changes
May 12, 2026
| env: | ||
| # github token required for testing update.py | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| COVERAGE_CORE: sysmon # for py>=3.12 this is much faster |
Member
There was a problem hiding this comment.
I would oppose putting coverage configuration in the CI yaml, because:
- This has nothing to do with CI and will make CI-debugging hard. -> maintenance burden
- The (theoretical) performance boost is negligible for CI pipelines. CI for PyJibe is not running that often anyway.
- sysmon will be the default in the future anyway: https://coverage.readthedocs.io/en/7.12.0/config.html#run-core
| "nanite>=4.2.3", | ||
| # https://github.com/AFM-analysis/PyJibe/issues/32 | ||
| "matplotlib>=3,<3.7.5", # NavigationToolbar2QT mod | ||
| "matplotlib>=3,<4", |
Member
There was a problem hiding this comment.
Shouldn't this be >3.7.5? (Does it work with old versions of matplotlib?)
Please keep the # NavigationToolbar2QT mod comment, because we are still doing that (right?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #32, we should support the newer python and matplotlib versions.
todos: