Bug fix in jvp updater (#94)#96
Closed
andrewfayres wants to merge 1 commit intoapeiron-package-restructurefrom
Closed
Bug fix in jvp updater (#94)#96andrewfayres wants to merge 1 commit intoapeiron-package-restructurefrom
andrewfayres wants to merge 1 commit intoapeiron-package-restructurefrom
Conversation
* Bug fix in jvp updater * fixed a bug, where batch norm would behave differntly with jvp and the other grads. Made everything but jvp inplace to save mem * Changes to pass mypy * Wip * format * Using the base updater when jvp doesn't have enough history --------- Co-authored-by: Steffen <steffen.schotthoefer@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix in jvp updater
fixed a bug, where batch norm would behave differntly with jvp and the other grads. Made everything but jvp inplace to save mem
Changes to pass mypy
Wip
format
Using the base updater when jvp doesn't have enough history
Summary
Motivation & Context
E.g. Fixes issue nr xyz
Approach
Screenshots / Logs (optional)
API / CLI Changes
foo.bar(x: int) -> str(new)baz(qux: PathLike)(removedstrict: bool)Breaking Changes
Performance (optional)
Security & Privacy
Dependencies
orjson>=3.10ujsonTesting Plan
python -m app --helpDocumentation
Checklist
ruff format --checkruff check .mypy srcpytest -qRisk & Rollback Plan
Probably not needed in the beginning
Notes for Reviewers