Skip to content

feat: add setters to toggle suppression during a session #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jim-smith merged 14 commits into from
Feb 2, 2026
Merged

feat: add setters to toggle suppression during a session #43

jim-smith merged 14 commits into from
Feb 2, 2026

Conversation

@jim-smith
Copy link
Collaborator

@jim-smith jim-smith commented Feb 2, 2026

No description provided.

@jim-smith jim-smith linked an issue Feb 2, 2026 that may be closed by this pull request
[New Feature Request]Add setters so user can toggle suppression during a session #42
Closed
@codecov
Copy link

codecov bot commented Feb 2, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8069069) to head (9d49e3a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          109       115    +6     
=========================================
+ Hits           109       115    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jim-smith jim-smith requested review from JessUWE and rpreen and removed request for rpreen February 2, 2026 13:28
@jim-smith
Copy link
Collaborator Author

jim-smith commented Feb 2, 2026

@rpreen @JessUWE there ar glitched when GitHub it tries to run the tests on their runners - but it is nowt to do without ur code - al works fine on may Mac, and error logs show it is to do with their runners.

@jim-smith jim-smith changed the title 42 new feature requestadd setters so user can toggle suppression during a session 42 [feat] add setters so user can toggle suppression during a session Feb 2, 2026
@rpreen rpreen changed the title 42 [feat] add setters so user can toggle suppression during a session feat: add setters to toggle suppression during a session Feb 2, 2026
jim-smith and others added 3 commits February 2, 2026 14:17
@jim-smith
Merge remote-tracking branch 'refs/remotes/origin/42-new-feature-requ…
0f19d0c 
…estadd-setters-so-user-can-toggle-suppression-during-a-session' into 42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session
@jim-smith
commented out old version of rhub
5925943
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6c26432 
for more information, see https://pre-commit.ci
rpreen
rpreen approved these changes Feb 2, 2026
View reviewed changes
Copy link
Collaborator

@rpreen rpreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS error looks like some kind of CI cache issue that should resolve later.

rpreen
rpreen reviewed Feb 2, 2026
View reviewed changes
NEWS.md Outdated
* Added support for toggling suppression dynamically during session via ```acro_enable_supression()```
and ```acro_disable_suppression()```
* Improved documentation in package and at [sacro-tools.org](sacro-tools.org)
* AddedSupport for variable names with spaces when calling crosstab
Copy link
Collaborator

@rpreen rpreen Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here? "AddedSupport"

rpreen
rpreen reviewed Feb 2, 2026
View reviewed changes
NEWS.md Outdated
* Added support for installation via conda
* Added support for specifying config files when acro session is started
* Added support for specifying whether suppression is on or off when acro session is started
* Added support for toggling suppression dynamically during session via ```acro_enable_supression()```
Copy link
Collaborator

@rpreen rpreen Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need single backticks for inline.

rpreen
rpreen reviewed Feb 2, 2026
View reviewed changes
inst/WORDLIST Outdated
@@ -1,41 +1,39 @@
ADR
Acknowledgement
AddedSupport
Copy link
Collaborator

@rpreen rpreen Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd

rpreen
rpreen requested changes Feb 2, 2026
View reviewed changes
Copy link
Collaborator

@rpreen rpreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@jim-smith
Copy link
Collaborator Author

jim-smith commented Feb 2, 2026

@rpreen fixed typos and number of ticks as per helpful comments.

I've spent a while trying to understand why the CI runners are failing for macosx and can't figure it out.
R has moved to a new version rhubv2 which is GitHub based and has dedicated runners on there and isn't macosx latest.
Don;t know how much effort it is to set that up? https://r-hub.github.io/rhub/reference/rhubv2.html

or do we just submit to CRAN without the checks on macosx?

@jim-smith
Merge remote-tracking branch 'refs/remotes/origin/42-new-feature-requ…
0ce8ff6 
…estadd-setters-so-user-can-toggle-suppression-during-a-session' into 42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session
@jim-smith
version should be 1.7
88277ef
@jim-smith
Remove version 0.1.8 entry from NEWS.md
9d49e3a 
Signed-off-by: Jim-smith <jim-smith@users.noreply.github.com>
@rpreen rpreen self-requested a review February 2, 2026 15:59
rpreen
rpreen approved these changes Feb 2, 2026
View reviewed changes
Copy link
Collaborator

@rpreen rpreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when ready. The macOS CI cache will probably clear on a later run.

@jim-smith jim-smith merged commit a9bf7c1 into main Feb 2, 2026
11 of 13 checks passed
@jim-smith jim-smith deleted the 42-new-feature-requestadd-setters-so-user-can-toggle-suppression-during-a-session branch February 2, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rpreen rpreen rpreen approved these changes

@JessUWE JessUWE Awaiting requested review from JessUWE

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[New Feature Request]Add setters so user can toggle suppression during a session

2 participants

@jim-smith @rpreen