Qualifier 296 fix + small Android support update#49
Conversation
EX0RCIST0N
commented
May 26, 2026
EX0RCIST0N
commented
- Fixed qualifiers for Windows platform and build 296 (removed from Action.cs and Condition.cs because changes in ACEventBase.cs and ParameterObject.cs fixes it)
- For Android - added .xapk reading, added unpacking videos if it was saved by Video Android extension (it won't add to Binary Files in the project)
- Fixed qualifiers for Windows platform and build 296 (removed from Action.cs and Condition.cs because changes in ACEventBase.cs and ParameterObject.cs fixes it) - For Android - added .xapk reading, added unpacking videos if it was saved by Video Android extension (it won't add to Binary Files in the project)
AITYunivers
left a comment
AITYunivers
left a comment
There was a problem hiding this comment.
Definitely not the strongest PR I've had to review.
| { | ||
| bool exists = Parent?.FrameEvents?.Qualifiers.Where(q => q.ObjectInfo == ObjectInfo && q.Type == ObjectType).Any() == true; | ||
| if (!exists) | ||
| Parent?.FrameEvents?.Qualifiers.Add(new Qualifier() { ObjectInfo = ObjectInfo, Type = ObjectType }); |
There was a problem hiding this comment.
Don't do this what-so-ever. If you're going to be redoing the Qualifiers, move this into ObjectCommon, instead of copy pasting it everywhere. Especially considering how removing this from Conditions and Actions is a stupid idea, only like 5% of ACEs use ParameterObject, I dunno what compelled you to do this.
|
|
||
| public ObjectInfo? GetObject() | ||
| { | ||
| // if Build >= 296, Windows and Fusion >= 2.5, has 0x8000 bit mask with qualifiers, return null |
There was a problem hiding this comment.
Do not edit anything related to the Event Dumper, this is deprecated and just shouldn't be used regardless, I am ashamed of it.
|
the thing about in ACEventBase.cs and ParameterObject is that for some actions and conditions it can't detect qualifier, even tho it's normally exists (0x8000 bit mask is of course doing this) |
|
You completely removed all the qualifier code, I'm unsure what the goal here was |
the main goal is to fix qualifiers as parameters, everything else works. |
|
Yeah I get that part but you're completely ignoring how I said to implement it in my review. |
moved it so it could still do the same thing, but also fix qualifiers as parameters in events
|
Thats not even remotely what I meant by that 😭 |
But through this GetObject method it determines is it object or qualifier, and only there could be fixed |
This reverts commit 038e118.
reverted changes with GetObject(), created 2 public static strings for getting qualifier's name in ObjectCommon and moved GetQualifierName method to ObjectCommon these changes do the same thing as in previous commit
ACEventBase changes is useless, so i reverted it, but bit mask check is still needed or else any changes for qualifiers won't do anything
2 participants
