fix(weixin): mitigate aiohttp connection pool poisoning#4
Merged
Conversation
…#60025) Add enable_cleanup_closed=True to the TCPConnector used for iLink connections so that server-closed keep-alive connections are properly cleaned up from the pool. Also adds a single retry when an asyncio.TimeoutError or aiohttp.ClientError is caught. Co-authored-by: Hermes Agent Ref aio-libs/aiohttp#12795
When aiohttp is not available, aiohttp is set to None. Referencing aiohttp.ClientError in except clauses caused AttributeError. Define _ClientError fallback to Exception when AIOHTTP_AVAILABLE is False.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR NousResearch#60044.
Fixes: NousResearch#60025
Pipeline: TRIAGE DONE | INTEGRATOR DONE | VERIFY PASS | REVIEWER APPROVED | SECURITY PENDING | OPSEC PENDING