test: add debug tool endpoint (canary for CodeQL shell injection dete…#43
Closed
atkaridarshan04 wants to merge 1 commit into
Closed
test: add debug tool endpoint (canary for CodeQL shell injection dete…#43atkaridarshan04 wants to merge 1 commit into
atkaridarshan04 wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return {"loaded_models": loaded} No newline at end of file | ||
|
|
||
| @router.get("/debug/tool") | ||
| def run_debug_tool(cmd: str) -> dict: |
Collaborator
Author
|
Verification done for CodeQL working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a deliberately vulnerable debug endpoint to verify that the CodeQL
security-extendedworkflow correctly detects and reports apy/shell-command-constructed-from-inputfinding on PRs targetingmain.Changes
GET /debug/tool?cmd=endpoint inapp/adapters/http/routes/debug.pythat passes an HTTP query parameter directly intosubprocess.run(..., shell=True)— a textbook shell injection vulnerabilityType
Testing
pytestpassesExpected CodeQL result: A
py/shell-command-constructed-from-inputalert should appear as an inline annotation onapp/adapters/http/routes/debug.pyin this PR's Files Changed tab, and under Security → Code scanning alerts.Related Issues
N/A — CodeQL workflow validation only