Fix/14 inspector exception handling#44
Merged
Merged
Conversation
Wrap the pickle inspection path in a top-level try/except so any unhandled exception (corrupt file, missing dependency, bad pickle) emits degraded metadata with framework=unknown rather than crashing the subprocess and killing the deploy command. inspect_artifact() now issues a warnings.warn when partial metadata is returned, allowing the deploy flow to continue. Closes #14
test_inspect_invalid_file previously asserted ValueError was raised on a corrupt pickle. Updated to assert the new contract: degraded metadata with framework=unknown and a warnings.warn instead of an exception.
atkaridarshan04
approved these changes
May 18, 2026
Collaborator
atkaridarshan04
left a comment
atkaridarshan04
left a comment
There was a problem hiding this comment.
LGTM. Approveed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix inspector subprocess crashing on any unhandled exception and killing the entire deploy command.
Changes
framework="unknown") instead of a non-zero exit
Type
Testing
Related Issues
Closes #14