fix(FC0004): use AZ Dev Tools-compatible permission sorting#251
Open
Arthurvdv wants to merge 1 commit into
Open
fix(FC0004): use AZ Dev Tools-compatible permission sorting#251Arthurvdv wants to merge 1 commit into
Arthurvdv wants to merge 1 commit into
Conversation
Replace OrdinalIgnoreCase string comparison with natural/alphanumeric sort that matches AZ Dev Tools' PermissionComparer behavior: - table/tabledata types sort first, grouped by name - Remaining types sort alphabetically by type keyword - Object names use natural sort (numeric chunks as integers) - Text chunks compared with spaces stripped and InvariantCultureIgnoreCase This fixes false positives on code formatted by AZ Dev Tools' Sort Permissions action. Closes #245 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes false positive in FC0004 where permission entries sorted by AZ Dev Tools' "Sort Permissions" action would still trigger the diagnostic.
Changes
Replaces the simple
OrdinalIgnoreCasestring comparison with a natural/alphanumeric sort that matches AZ Dev Tools'PermissionComparerbehavior:Item 2<Item 10)InvariantCultureIgnoreCasefor text chunksNew files
src/ALCops.Common/Permissions/NaturalNameComparer.cs- Natural/alphanumeric string comparerTest coverage
Closes #245