fix: handle table names containing dots in AC0031 CodeFix (#340)#352
Merged
Conversation
fix: handle table names containing dots in AC0031 CodeFix (#339) The CodeFix previously used LastIndexOf('.') to detect namespace qualification, treating dots within table names (e.g. "ABC Example Header.Line") as namespace separators. This produced invalid syntax like tabledata "ABC Example Header"."Line" = r. Restructured the API to pass namespace and table name as separate parameters via a new ResolvedTableName struct, eliminating the fragile parse-from-combined-string pattern entirely. Also fixed multi-segment namespace handling: CreateObjectReference previously passed namespaces like "MyPTE.Sales" as a single IdentifierName, rendering them as a quoted identifier. It now builds nested QualifiedName nodes so MyPTE.Sales."ABC Example Header.Line" renders correctly. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles AL table names containing dots (namespaced/dotted names) in the AC0031 CodeFix.
Moved into
mainfromrelease/v1.0.0(commitb36a808, originally PR #340) so it lands without implying a v1.0.0 release. Independent of the other split PRs.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com