fix: include ApprovalTests as transitive dependency#17
Merged
Conversation
Remove PrivateAssets="all" and reduce ExcludeAssets to "build;buildTransitive" on all three TFM-specific ApprovalTests PackageReference entries. Previously, ApprovalTests was fully excluded from runtime assets, causing FileNotFoundException when DiffHelper.TryToReportDiffWithExternalTool tried to instantiate DiffReporter in consumer test projects. The build/buildTransitive exclusion is retained to prevent ApprovalTests' MSBuild targets from interfering with deterministic compilation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DiffHelper.TryToReportDiffWithExternalToolthrowsFileNotFoundExceptionforApprovalTestsassembly when consumer test projects hit a code-action diff mismatch. This is because ApprovalTests was marked withPrivateAssets="all"and its runtime assets were excluded.Fix
PrivateAssets="all"so ApprovalTests flows as a transitive dependency to consumersExcludeAssetsto"build;buildTransitive"(retains exclusion of MSBuild targets that may affect deterministic compilation)PackageReferenceentries (netstandard2.1, net8.0, net10.0)Verification
dotnet-validatedeterministic check expected to pass (build targets still excluded)