feat: add TestFixAll method to CodeFixTestFixture#18
Merged
Conversation
Add FixAll testing support to catch bugs where individual code fixes work but applying all fixes simultaneously fails (e.g., overlapping text changes silently dropped by BatchFixer). New public API: - CodeFixTestFixture.TestFixAll(markupCode, expected, diagnosticId) - CodeFixTestFixture.TestFixAll(markupCode, expected, descriptor) Implementation: - TestDiagnosticProvider: implements FixAllContext.DiagnosticProvider for feeding pre-computed diagnostics to the FixAll infrastructure - Auto-detects EquivalenceKey from first diagnostic's CodeAction - Asserts marker count matches diagnostic count - Uses FixAllScope.Document, tests the CodeFix's real FixAllProvider Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds FixAll testing support to
CodeFixTestFixtureto catch bugs where individual code fixes work but applying all fixes simultaneously fails (e.g., overlapping text changes silently dropped byBatchFixer).New Public API
How it works
[| |]markers to identify expected diagnostic locationsEquivalenceKeyfrom the first diagnostic's CodeActionFixAllContextwith a customDiagnosticProvideratFixAllScope.DocumentscopeFixAllProvider.GetFixAsync()Files changed
TestDiagnosticProvider.csFixAllContext.DiagnosticProviderCodeFixTestFixture.csTestFixAlloverloadsRoslynTestKitException.csREADME.md