fix: cross-platform line ending normalization in CodeFix tests#19
Merged
Merged
Conversation
Verify.CodeAction() normalized only the actual code fix output (CRLF→LF on Linux/macOS) but not the expected code from fixture files. This caused all HasFix tests to fail on Linux/WSL when fixture files had CRLF endings. Replace platform-specific ConvertToLineEndingsAwareString with an unconditional NormalizeLineEndings that normalizes both actual and expected to LF before comparison, making tests stable across all platforms regardless of git autocrlf settings or OS line endings. Also fixes a bug where multi-document comparison reused the wrong SourceText variable (sourceText instead of docSourceText). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verify.CodeAction(), making HasFix tests stable across Windows, Linux, and macOS regardless of gitcore.autocrlfsettingsConvertToLineEndingsAwareString(only normalized actual output on Linux/macOS) with unconditionalNormalizeLineEndingsapplied to both sidesSourceTextvariable (sourceTextinstead ofdocSourceText)Context
All 135 HasFix tests in ALCops Analyzers fail on Linux/WSL because:
.alfixture files have CRLF (fromgit core.autocrlf=true)ConvertToLineEndingsAwareStringstrips CRLF→LF on the actual code fix output on LinuxactualCode != expectedCode) compares LF vs CRLF → always failsTest plan
🤖 Generated with Claude Code