Apply ruleset to compilation so tests can enable default-disabled diagnostics#20
Merged
Merged
Conversation
…gnostics BaseTestFixture exposed RuleSetPath but only passed it to ProjectInfo, which the in-memory AdhocWorkspace never applies to the compilation's diagnostic options. Load the ruleset via RuleSetResolver and merge its general and per-rule options into the CompilationOptions used to build the test project. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseTestFixtureexposedRuleSetPathvia the fixture configs, but it was only forwarded toProjectInfo.RuleSetPath. The in-memoryAdhocWorkspacebuilds the compilation fromProjectState.CompilationOptionsand never applies the ruleset, soRuleSetPathwas effectively a no-op for diagnostics.This change loads the ruleset and applies it to the compilation's diagnostic options, so tests can enable/disable diagnostics — in particular, enabling rules declared
isEnabledByDefault: false.Changes
BaseTestFixture.CreateDocumentFromCode: after computingCompilationOptions, call newApplyRuleSet(...)helper.ApplyRuleSet: loads the ruleset viaRuleSetResolver.LoadFromFile(...)and mergesGeneralDiagnosticOption+SpecificDiagnosticOptionsonto the options. ThrowsRoslynTestKitException.InvalidRuleSeton load errors.RoslynTestKitException.InvalidRuleSet(...): new factory for clear failures on invalid/missing ruleset files.README.md: document thatRuleSetPathis now applied, with a JSON ruleset example for enabling default-disabled diagnostics.Notes
#ifguards needed.ProjectInfo.RuleSetPathplumbing is left intact (harmless).Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com