feat: use vsts-task-installer User-Agent for NuGet download statistics#15
Merged
Conversation
Change the NuGet download User-Agent from custom 'ALCops-AzureDevOps'
to 'vsts-task-installer/{version} (Node.js {v}; {os} {release})' which
matches a recognized known client pattern in NuGet.org's CDN log parser
(knownclients.yaml), making ALCops.Analyzers downloads visible in
per-package statistics and distinguishable from the VS Code extension.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the NuGet download User-Agent from custom
ALCops-AzureDevOpstovsts-task-installer/{version}which matches a recognized known client pattern in NuGet.org's CDN log parser (knownclients.yaml), making ALCops.Analyzers downloads visible in per-package statistics.This mirrors what was done for the VS Code extension in ALCops/vscode-extension#34, but uses a different known client name (
vsts-task-installervsNuGet VS VSIX) so downloads from each extension are distinguishable.Changes
shared/user-agent.tsvsts-task-installer/{version} (Node.js ...; ...)tests/shared/user-agent.test.tstasks/install-analyzers/src/nuget-api.tsgetUserAgent()with task.json version instead of hardcoded stringtests/install-analyzers/nuget-api.test.ts.github/copilot-instructions.mdWhy
vsts-task-installer?knownclients.yaml(no upstream PR needed)vsts-task-installerdownloads for this package are effectively zero