fix: honor #pragma warning disable in analyze, get_fixes, and apply_fix tools#9
Merged
Merged
Conversation
…ix tools GetAnalyzerDiagnosticsAsync() returns raw diagnostics without applying pragma suppression. Pipe results through GetEffectiveDiagnostics() and filter IsSuppressed to match IDE behavior. Closes #8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetAnalyzerDiagnosticsAsync()returns raw diagnostics without applying#pragma warning disable/restoresuppression. Piped results through the SDK'sCompilationWithAnalyzers.GetEffectiveDiagnostics()and filtered outIsSuppresseddiagnostics in bothDiagnosticsRunnerandCodeFixRunnerCloses #8
Test plan
dotnet buildsucceedsdotnet testpasses (4/4 tests, including newRunAsync_PragmaSuppressedDiagnostics_AreNotReported)alcops-mcpanalyze on an AL file with#pragma warning disable AA0137and verify AA0137 is not reported inside the pragma block🤖 Generated with Claude Code