Fixed warnings and errors when checking with Dymola.#28
Closed
christoff-buerger wants to merge 1 commit into
Closed
Fixed warnings and errors when checking with Dymola.#28christoff-buerger wants to merge 1 commit into
christoff-buerger wants to merge 1 commit into
Conversation
Classes extending Layer are blocks; to extend a model in a block is invalid Modelica => changed Layer type from model to block. The example networks connect in- and outputs with layers via component modification. This in invalid Modelica => changed to proper connect equation. The NARX_Network example leverages on propagating sizes via the connector. Again, this is not supported by the Modelica specification. => Sizes are now provided via redeclaration of the in- and outputs with size information. General comment: The current library design breaks with MSL design, where MIMO interfaces must have size parameters that are used to properly set the sizes. This is a rather big design issue.
|
|
auto-merge was automatically disabled
September 5, 2025 23:29
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes are based on test in Dymola. The items marked WARNING do not prevent simulation, but the ones marked ERROR result in translation errors and therefore prohibit simulation in Dymola.
WARNING: Classes extending Layer are blocks; to extend a model in a block is invalid Modelica => changed Layer type from model to block.
ERROR: The example networks connect in- and outputs with layers via component modification. This in invalid Modelica => changed to proper connect equations.
ERROR: The NARX_Network example leverages on propagating sizes via the connector. Again, this is not supported by the Modelica specification => sizes are now provided via redeclaration of the in- and outputs with size information. In general, the current library design for modeling sizes breaks with MSL design, where MIMO interfaces must have size parameters that are used to properly set the sizes. This is a rather big design issue that needs rethinking how to model the sizes proper.