Skip to content

Fixed warnings and errors when checking with Dymola.#28

Closed
christoff-buerger wants to merge 1 commit into
AMIT-HSBI:mainfrom
christoff-buerger:warnings-fix-and-pedantic-checks
Closed

Fixed warnings and errors when checking with Dymola.#28
christoff-buerger wants to merge 1 commit into
AMIT-HSBI:mainfrom
christoff-buerger:warnings-fix-and-pedantic-checks

Conversation

@christoff-buerger

Copy link
Copy Markdown

The following changes are based on test in Dymola. The items marked WARNING do not prevent simulation, but the ones marked ERROR result in translation errors and therefore prohibit simulation in Dymola.

WARNING: Classes extending Layer are blocks; to extend a model in a block is invalid Modelica => changed Layer type from model to block.

ERROR: The example networks connect in- and outputs with layers via component modification. This in invalid Modelica => changed to proper connect equations.

ERROR: The NARX_Network example leverages on propagating sizes via the connector. Again, this is not supported by the Modelica specification => sizes are now provided via redeclaration of the in- and outputs with size information. In general, the current library design for modeling sizes breaks with MSL design, where MIMO interfaces must have size parameters that are used to properly set the sizes. This is a rather big design issue that needs rethinking how to model the sizes proper.

Classes extending Layer are blocks; to extend a model in a block is invalid Modelica => changed Layer type from model to block.

The example networks connect in- and outputs with layers via component modification. This in invalid Modelica => changed to proper connect equation.

The NARX_Network example leverages on propagating sizes via the connector. Again, this is not supported by the Modelica specification. => Sizes are now provided via redeclaration of the in- and outputs with size information. General comment: The current library design breaks with MSL design, where MIMO interfaces must have size parameters that are used to properly set the sizes. This is a rather big design issue.
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@christoff-buerger christoff-buerger changed the title Fixed warnings are errors when checking with Dymola. Fixed warnings and errors when checking with Dymola. May 14, 2025
@phannebohm phannebohm enabled auto-merge (rebase) May 14, 2025 09:58
@phannebohm phannebohm disabled auto-merge May 14, 2025 09:58
@phannebohm phannebohm enabled auto-merge (squash) May 14, 2025 10:00
auto-merge was automatically disabled September 5, 2025 23:29

Pull request was closed

@christoff-buerger christoff-buerger deleted the warnings-fix-and-pedantic-checks branch September 5, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants