Fix out-of-bounds error in IncfloVelFill when doing u_mac fillpatch#146
Merged
asalmgren merged 6 commits intoAMReX-Fluids:developmentfrom Jun 3, 2025
Merged
Fix out-of-bounds error in IncfloVelFill when doing u_mac fillpatch#146asalmgren merged 6 commits intoAMReX-Fluids:developmentfrom
asalmgren merged 6 commits intoAMReX-Fluids:developmentfrom
Conversation
Collaborator
Author
|
@asalmgren I'm not sure if this fix could potentially break other things. I don't think it's ever the case for incflo that in IncfloVelFill |
component in the closest valid cell instead. Must use bigEnd/smallEnd because if ng>1, i+1 could still be a ghost cell.
asalmgren
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.