Add option to evolve temperature eqn#149
Merged
asalmgren merged 23 commits intoAMReX-Fluids:developmentfrom Jun 6, 2025
Merged
Add option to evolve temperature eqn#149asalmgren merged 23 commits intoAMReX-Fluids:developmentfrom
asalmgren merged 23 commits intoAMReX-Fluids:developmentfrom
Conversation
some progress on updates elsewhere...
commit d792c63 Author: Weiqun Zhang <WeiqunZhang@lbl.gov> Date: Wed Sep 11 10:07:00 2024 -0500 Simplify cache cleanup actions (AMReX-Fluids#129) In our old approach, a workflow file contains a job that uploads the PR number as an artifact. While the PR is still open, the workflow_run triggered by it will download the artifact and use the information to clean up all except the last used cache associated with that original workflow. When a PR is merged or closed, there will be a post-pr workflow that uploads the PR number as an artifact and triggers a workflow_run that clean up all caches associated with the PR. The reason we did it this way was in the cache cleanup workflows, we did not find an easy way to get the number of the PR triggering them. This is not convenient because we have to add jobs uploading artifacts to workflow files. After some experiments, we have found a reliable way to find the PR number without using artifacts. The workflow_run's payload always contains the head SHA of the commit that triggers it, whether the PR comes from a fork or not. We can then use `gh pr list` to search for that head and obtain the PR number. commit a007c21 Author: Candace Gilet <cgilet@users.noreply.github.com> Date: Wed Sep 11 16:57:56 2024 +0200 Fix case of multiple tracers with default initial conditions. Issue (AMReX-Fluids#132) introduced in PR#131
commit a7f9213 Author: Candace Gilet <cgilet@users.noreply.github.com> Date: Tue Sep 17 16:34:26 2024 +0200 For time-dependent BCs, need to pass the real time when (AMReX-Fluids#133) FillPatching umac. commit d792c63 Author: Weiqun Zhang <WeiqunZhang@lbl.gov> Date: Wed Sep 11 10:07:00 2024 -0500 Simplify cache cleanup actions (AMReX-Fluids#129) In our old approach, a workflow file contains a job that uploads the PR number as an artifact. While the PR is still open, the workflow_run triggered by it will download the artifact and use the information to clean up all except the last used cache associated with that original workflow. When a PR is merged or closed, there will be a post-pr workflow that uploads the PR number as an artifact and triggers a workflow_run that clean up all caches associated with the PR. The reason we did it this way was in the cache cleanup workflows, we did not find an easy way to get the number of the PR triggering them. This is not convenient because we have to add jobs uploading artifacts to workflow files. After some experiments, we have found a reliable way to find the PR number without using artifacts. The workflow_run's payload always contains the head SHA of the commit that triggers it, whether the PR comes from a fork or not. We can then use `gh pr list` to search for that head and obtain the PR number. commit a007c21 Author: Candace Gilet <cgilet@users.noreply.github.com> Date: Wed Sep 11 16:57:56 2024 +0200 Fix case of multiple tracers with default initial conditions. Issue (AMReX-Fluids#132) introduced in PR#131
BC. Still needs test problem
…ure_eqn Conflicts: src/setup/incflo_arrays.cpp
flow though EB. Also remove unneeded set_density_eb and set_tracer_bc from ApplyNodalProjection
it's used for two regression tests. This reverts commit 5f5d3bc.
asalmgren
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not yet couple back into fluid or work with MOL advection scheme.
Includes updated benchmark.channel_spherecube to include temperature solve with Dirichlet BC on EB in regression tests.