You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here I add an option to customize IP address and Port number for mock Unicast DNS server of nmos-testing-tool.
This allows for easier use of this mock:
no need to do elevated permissions when use privileged port (53).
no conflicts with already present DNS services in system.
no conflicts with DHCP services which might already provide DNS server addresses.
Configure custom IP:Port for mock DNS server and use it in Your client code.
What is done:
added 'None' values for CONFIG.DNS_IP and CONFIG.DNS_PORT variables (Config.py)
elevated permissions check in NMOSTesting.py modified to not start when DNS_PORT is initialized to any value
DNS.Py: modified code for DNS server start/stop and logging
Can I ask the motivation for being able to change the DNS IP address?
Also, although it is possible to change the port that clients use for DNS, it is non standard and not recommended, How have you been configuring your platforms to use a non-standard DNS port?
Hey!
First, it allows to not require elevated permissions. And this makes using of the utility a lot simpler.
Second, it allows testing utility to not interfere with already present DNS servers.
Additional bonus: testing utility automatically chooses IP address which constantly change when You connect to different WiFi networks. You can set it to 127.0.1.1 and it will stay available and well-known no matter where You work (useful if You work when outside Your Office/Home).
Personally, I'm using my own DNS SD implementation so I don't need to reconfigure my system to use customized ports.
Think, this feaure might be useful in some (rare) cases while not being overall bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I add an option to customize IP address and Port number for mock Unicast DNS server of nmos-testing-tool.
This allows for easier use of this mock:
Configure custom IP:Port for mock DNS server and use it in Your client code.
What is done: