Open
Conversation
… feature/online
Feature/clustering
Feature/online
There was a problem hiding this comment.
Pull Request Overview
This PR implements various enhancements and new features across the codebase, including utility improvements, new scheduling algorithms, and updated visualization functions that support dynamic labeling and transcript callbacks. Key changes include:
- Adding a round method and new comparison operators in RandomVariable.
- Updating drawing functions to support dynamic font sizing and label rotation.
- Introducing MSTScheduler and integrating transcript callbacks and clustering in HEFT, CPoP, and other scheduler modules.
Reviewed Changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/saga/utils/random_variable.py | Added round and comparison operators; note round does not perform rounding. |
| src/saga/utils/draw.py | Updated drawing functions with dynamic labeling parameters and transcript callbacks. |
| src/saga/schedulers/mst.py | Introduced MSTScheduler for minimum start time scheduling. |
| src/saga/schedulers/heft.py | Enhanced HEFT scheduling with transcript callbacks and clustering support. |
| src/saga/schedulers/etf.py | Updated function signature to support optional clustering on scheduling. |
| src/saga/schedulers/data/wfcommons.py | Modified workflow conversion and network generation with optional random variable weights. |
| src/saga/schedulers/cpop.py | Added transcript callbacks and clustering support to CPoP scheduling. |
| src/saga/schedulers/init.py | Integrated MSTScheduler into the scheduler registry. |
| scripts/examples/* | Updated examples to incorporate new scheduler parameters and output file types. |
Files not reviewed (2)
- scripts/examples/online/.gitignore: Language not supported
- scripts/examples/stochastic/.gitignore: Language not supported
Comments suppressed due to low confidence (2)
src/saga/utils/draw.py:579
- The variable 'font_size' is used but not defined in the current scope of gradient_heatmap. Ensure that 'font_size' is either defined or passed as a parameter to the function.
ax.set_xticklabels(xvals, rotation=rotate_xlabels, fontsize=font_size)
src/saga/utils/draw.py:580
- The variable 'font_size' is referenced here without a definition in the scope. Consider defining 'font_size' or making it a function parameter to ensure consistent behavior.
ax.set_yticklabels(yvals, fontsize=font_size)
Comment on lines
+42
to
43
| return self | ||
|
|
There was a problem hiding this comment.
The round method currently does not apply any rounding logic and simply returns self. Consider implementing proper rounding on the underlying random variable data.
Suggested change
| return self | |
| rounded_samples = np.round(self.samples, n) | |
| return RandomVariable(rounded_samples) |
…eriments, also closed gnatts graphs that were generated to avoid runtime error.
…ametric experiments
…e/wfcommons-fix
…blems as well as file to break down CTG into static problem instances
…conditional branches so that there are no uneccesary gaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.