Makes FFI-MEM-WRAPPING example a bit more Rusty#56
Open
Voronar wants to merge 2 commits intoANSSI-FR:masterfrom
Open
Makes FFI-MEM-WRAPPING example a bit more Rusty#56Voronar wants to merge 2 commits intoANSSI-FR:masterfrom
Voronar wants to merge 2 commits intoANSSI-FR:masterfrom
Conversation
danielhenrymantilla
approved these changes
Jan 26, 2022
Contributor
danielhenrymantilla
left a comment
There was a problem hiding this comment.
I personally do like the changes; I'd kind of suggest that ptr::NonNull<Foo> be used instead of a through-&mut raw pointer, because the semantics w.r.t. aliasing are not exactly the same, and that when aliasing is involved things would be a bit more subtle. Raw pointers are better at dodging aliasing assumptions with the compiler:
- pub struct Foo(*mut RawFoo);
+ pub struct Foo(ptr::NonNull<RawFoo>);
…
impl Foo {
/// Create a Foo
pub fn new() -> Option<Foo> {
// The `?` operator here ensures `None` is returned on `NULL`.
- let raw_ptr = unsafe { foo_create().as_mut()? };
+ let raw_ptr = ptr::NonNull::new(unsafe { foo_create() })?;etc.
Co-authored-by: Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>
Contributor
|
I think |
polazarus
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.