Skip to content

chore: sync Version.props from SDK#56

Merged
ANcpLua merged 1 commit intomainfrom
auto/sync-version-props
Feb 14, 2026
Merged

chore: sync Version.props from SDK#56
ANcpLua merged 1 commit intomainfrom
auto/sync-version-props

Conversation

@ANcpLua
Copy link
Owner

@ANcpLua ANcpLua commented Feb 14, 2026

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • Chores
    • Updated versions for multiple internal development tools including code coverage and diagnostics analyzers
    • Removed legacy dependencies from build configuration
    • Updated service defaults documentation references

Copilot AI review requested due to automatic review settings February 14, 2026 16:22
@ANcpLua ANcpLua merged commit dc54cda into main Feb 14, 2026
@ANcpLua ANcpLua deleted the auto/sync-version-props branch February 14, 2026 16:22
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist
Copy link

Summary of Changes

Hello @ANcpLua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request synchronizes the Version.props file with the latest SDK versions. It primarily involves updating various package dependency versions and removing a section related to legacy polyfills, ensuring that the project aligns with current library requirements and best practices.

Highlights

  • Dependency Version Updates: Updated several dependency versions, including CodeCoverageVersion, DiagnosticsTestingVersion, ANcpLuaAnalyzersVersion, and BannedApiAnalyzersVersion to newer releases.
  • YamlDotNet Version Adjustment: The YamlDotNetVersion was adjusted from 16.3.1 to 16.3.0.
  • Removal of Legacy Polyfills: The entire PropertyGroup for 'Legacy Polyfills', which included BclAsyncInterfacesVersion, TasksExtensionsVersion, and BclHashCodeVersion, was removed from the Version.props file.
  • OpenTelemetry Comment Update: A comment related to OpenTelemetry usage was updated for clarity.
Changelog
  • Version.props
    • Updated CodeCoverageVersion from 18.1.0 to 18.4.1.
    • Updated DiagnosticsTestingVersion from 10.0.0 to 10.3.0.
    • Updated ANcpLuaAnalyzersVersion from 1.16.0 to 1.19.1.
    • Updated BannedApiAnalyzersVersion from 3.3.4 to 4.14.0.
    • Changed YamlDotNetVersion from 16.3.1 to 16.3.0.
    • Removed the PropertyGroup for 'Legacy Polyfills' and its associated versions (BclAsyncInterfacesVersion, TasksExtensionsVersion, BclHashCodeVersion).
    • Modified the comment for the OpenTelemetry PropertyGroup.
Activity
  • This pull request was automatically generated by the create-pull-request GitHub action, indicating an automated synchronization task.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Updated version numbers for multiple dependencies in Version.props (CodeCoverageVersion, DiagnosticsTestingVersion, ANcpLuaAnalyzersVersion, BannedApiAnalyzersVersion, YamlDotNetVersion). Removed legacy polyfills group containing BclAsyncInterfacesVersion, TasksExtensionsVersion, and BclHashCodeVersion. Updated OpenTelemetry comment to reference web projects with qyl ServiceDefaults.

Changes

Cohort / File(s) Summary
Version Configuration
Version.props
Updated dependency versions for code coverage, diagnostics testing, analyzers, and YAML processing. Removed legacy polyfills section (BclAsyncInterfaces, TasksExtensions, BclHashCode). Updated OpenTelemetry comment from "Consumer web projects" to "Web projects (qyl ServiceDefaults)".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch auto/sync-version-props

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains automated updates to dependency versions in Version.props. While most changes are version upgrades, I've identified two potential issues: a dependency downgrade for YamlDotNetVersion and the removal of a Legacy Polyfills section that may still be required for netstandard2.0 support. These changes could introduce bugs or cause build failures.

I am having trouble creating individual review comments. Click here to see my feedback.

Version.props (162)

high

The version of YamlDotNet is being downgraded from 16.3.1 to 16.3.0. This is a potential issue as downgrades can reintroduce bugs or security vulnerabilities that were fixed in the later version. Unless there is a specific reason for this downgrade (e.g., a regression in the newer version), it is recommended to use the latest version.

    <YamlDotNetVersion>16.3.1</YamlDotNetVersion>

Version.props (165-173)

high

The Legacy Polyfills property group, which provided versions for netstandard2.0 support, has been removed. However, ANcpLua.Analyzers.csproj continues to target netstandard2.0. This could lead to build failures for the netstandard2.0 target if any part of the build process relies on these version properties (BclAsyncInterfacesVersion, TasksExtensionsVersion, BclHashCodeVersion). If these properties are still in use, this change should be reverted.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is an automated pull request that syncs package version definitions from the ANcpLua.NET.Sdk repository (the source of truth for versions) to the ANcpLua.Analyzers repository. The changes update several package versions used for testing and analysis, remove an unused Legacy Polyfills section, improve a comment, and fix a minor formatting issue.

Changes:

  • Update multiple package versions including test platform extensions, analyzers, and dependencies
  • Remove unused Legacy Polyfills PropertyGroup section (BclAsyncInterfacesVersion, TasksExtensionsVersion, BclHashCodeVersion)
  • Improve OpenTelemetry comment to clarify usage in qyl ServiceDefaults

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<BclAsyncInterfacesVersion>6.0.0</BclAsyncInterfacesVersion>
<TasksExtensionsVersion>4.5.4</TasksExtensionsVersion>
<BclHashCodeVersion>6.0.0</BclHashCodeVersion>
<YamlDotNetVersion>16.3.0</YamlDotNetVersion>
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YamlDotNetVersion is being downgraded from 16.3.1 to 16.3.0. This appears to be a regression rather than an upgrade. Version downgrades can introduce bugs that were fixed in the newer version and should be avoided unless there's a specific reason for the rollback.

Suggested change
<YamlDotNetVersion>16.3.0</YamlDotNetVersion>
<YamlDotNetVersion>16.3.1</YamlDotNetVersion>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant