Feature/projects card zoom#586
Conversation
Make the Ideas page CTA respond to hover with green in light mode and yellow in dark mode. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughThe pull request replaces a FontAwesome Twitter icon with a custom XIcon component across the footer and homepage, updates its label to reference "X (Twitter)", and applies consistent visual polish through hover-scale animations to multiple card components while enhancing button/link styling with comprehensive Tailwind classes for better accessibility and dark mode support. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/ideas/2024/index.jsx (1)
17-27:⚠️ Potential issue | 🟠 MajorMUI inline
transitionoverrides Tailwind'stransition-transform, breaking the scale animation.The
sxprop on Line 27 setstransition: 'background-color 0.3s ease'as an inline style, which takes precedence over the Tailwindtransition-transform duration-200class on Line 17. The result is that thehover:scale-105effect will snap instantly instead of animating smoothly.Either remove the
sxtransition and handle it via Tailwind, or combine both transition properties:Option A: Merge in sx
- transition: 'background-color 0.3s ease', + transition: 'background-color 0.3s ease, transform 0.2s ease',…and drop the Tailwind
transition-transform duration-200classes.Option B: Move background transition to Tailwind
- className="dark:bg-[`#2A2A2A`] dark:border-white transform transition-transform duration-200 hover:scale-105" + className="dark:bg-[`#2A2A2A`] dark:border-white transition-all duration-200 hover:scale-105"- transition: 'background-color 0.3s ease',The same issue exists in
src/pages/ideas/index.jsx(Line 27).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/ideas/2024/index.jsx` around lines 17 - 27, The inline sx prop sets transition: 'background-color 0.3s ease' which overrides the Tailwind className 'transition-transform duration-200 hover:scale-105' and prevents the scale animation; fix by either removing the inline transition from the sx prop so Tailwind handles transitions, or broaden the sx transition to include transform (e.g. 'background-color 0.3s ease, transform 200ms') so both background and transform animate, and apply the same change to the other occurrence with the same className/sx combination.
🧹 Nitpick comments (1)
src/pages/apply.jsx (1)
145-151: Consider addingtarget="_blank"andrel="noopener noreferrer"for the external link.This links to
https://summerofcode.withgoogle.com/— an external site. Users likely expect it to open in a new tab, and it should includerel="noopener noreferrer"for security.<Link className="order-1 group relative inline-flex items-center overflow-hidden rounded-lg bg-white px-8 py-3 font-mono font-semibold text-[`#00843D`] shadow-sm ring-1 ring-black/10 transition hover:bg-[`#00843D`] hover:text-white focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[`#00843D`] focus-visible:ring-offset-2 dark:bg-black dark:text-yellow-400 dark:ring-white/15 dark:hover:bg-yellow-400 dark:hover:text-black dark:focus-visible:ring-yellow-400 dark:focus-visible:ring-offset-2 dark:focus-visible:ring-offset-black" href="https://summerofcode.withgoogle.com/" + target="_blank" + rel="noopener noreferrer" >🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/apply.jsx` around lines 145 - 151, The external Link component rendering the GSoC URL should open in a new tab and be secured; update the Link element (the JSX Link with href="https://summerofcode.withgoogle.com/") to include target="_blank" and rel="noopener noreferrer" so the link opens in a new tab and prevents window.opener/security risks.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/pages/ideas/2024/index.jsx`:
- Around line 17-27: The inline sx prop sets transition: 'background-color 0.3s
ease' which overrides the Tailwind className 'transition-transform duration-200
hover:scale-105' and prevents the scale animation; fix by either removing the
inline transition from the sx prop so Tailwind handles transitions, or broaden
the sx transition to include transform (e.g. 'background-color 0.3s ease,
transform 200ms') so both background and transform animate, and apply the same
change to the other occurrence with the same className/sx combination.
---
Duplicate comments:
In `@src/pages/ideas/index.jsx`:
- Around line 17-27: The MUI sx block defines a "transition" property which
overwrites Tailwind's transition-transform on the element (className includes
"transition-transform"); to fix, edit the sx object (same element with className
and sx) and either remove the "transition" entry or change it to include
transform (e.g., replace transition: 'background-color 0.3s ease' with
transition: 'background-color 0.3s ease, transform 0.2s ease' or use
transitionProperty: 'background-color, transform') so Tailwind's scale hover
animation is preserved while keeping the background-color transition.
---
Nitpick comments:
In `@src/pages/apply.jsx`:
- Around line 145-151: The external Link component rendering the GSoC URL should
open in a new tab and be secured; update the Link element (the JSX Link with
href="https://summerofcode.withgoogle.com/") to include target="_blank" and
rel="noopener noreferrer" so the link opens in a new tab and prevents
window.opener/security risks.
Summary by CodeRabbit
New Features
UI/UX Improvements