Merged
Conversation
Fix the errors in _r0_to_cn2_ and r0_to_seeing as described in AOtools#88
add master branch to building docs template
- Updated Python versions in AppVeyor and GitHub workflows to 3.10, 3.11, and 3.12. - Changed testing framework from nosetests to pytest. - Enhanced requirements with specific version constraints for numpy, scipy, matplotlib, numba, and pytest. - Added pyproject.toml for build system configuration. - Corrected README typo from PYTHONTPATH to PYTHONPATH. - Updated setup.py to use setuptools and improved package installation instructions.
Member
Author
|
I think this is working correctly now. The issues are:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s packaging and CI setup to target newer Python versions, migrate test execution to pytest, and tighten dependency/version constraints to better reflect a modern build and test environment.
Changes:
- Updated CI workflows (GitHub Actions, AppVeyor, CodeQL) to newer action versions and Python 3.10–3.12 (per PR intent).
- Switched CI test execution from
noseteststopytestand updated installation steps topip install .. - Added
pyproject.tomlbuild-system config and applied minimum version constraints across requirements/install dependencies.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
test/requirements.txt |
Adds minimum version constraints for test dependencies. |
setup.py |
Moves to setuptools + find_packages(), adds python_requires, and constrains runtime deps. |
requirements.txt |
Pins minimum versions for CI-installed deps (pytest/coverage included). |
README.rst |
Fixes PYTHONPATH typo and updates source install command to pip install .. |
pyproject.toml |
Adds PEP 517/518 build-system configuration. |
doc/source/conf.py |
Improves mocking for importlib behavior and updates Sphinx settings/intersphinx mapping. |
appveyor.yml |
Updates Windows CI environment and switches to pytest-based runs. |
.github/workflows/unit_test.yml |
Expands test matrix to 3.10–3.12 and modernizes actions + install steps. |
.github/workflows/documentation.yml |
Modernizes actions and ensures pip is upgraded before installing docs deps. |
.github/workflows/codeql-analysis.yml |
Updates CodeQL workflow branches and action versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CI configuration, dependencies.