Merged
Conversation
…ing numerical issues
Member
|
Do you think this could be related to what I was seeing in #109 ? |
Contributor
Author
|
Could well be! We have been having some issues with infinite phase screens for a while now, but more looking at the spatial/temporal covariances which were never quite matching the theory. I think this fixes that. |
Member
|
Even if it doesn't its worth fixing the covariances! The packaging is completley broken at the moment as is the tests as I've neglected the package for too long now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phase_covariance function was converting the input to float32, which was causing numerical precision issues which propagated through to the infinite phase screens (and possibly elsewhere). I have changed this to float64 which seems to resolve this.