feat(jetson): emit parseable OK/FAILED result lines from camera and fan checks#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Jetson camera and fan check scripts now print one machine-readable result line per device, so the manufacturing bench test can surface the specific failure cause rather than a bare pass/fail.
Problem
The scripts emitted free-form, inconsistent output:
check_cameras.shprintedCamera /dev/videoN: SUCCESS/FAILED to confirm status, andcheck_fan.shburied its outcome in pages of ramp diagnostics. A caller could read the exit code but not why a check failed, so every failure collapsed to a generic boolean.Solution
check_cameras.shprints one parseable line per device —/dev/videoN: OK - <fps>or/dev/videoN: FAILED: <reason>(not found/no frames).check_fan.shends with a singlefan: OKorfan: FAILED: <reason>line, the reason set at each failure point (e.g.rpm 0 at full speed,no pwm-fan device). Exit codes are unchanged.