fix(frontend): scope full-width layout to the Video route#96
Merged
Conversation
962f4f8 fixed the Video page by setting width:100% on #app, but since #app is a shrink-wrapping flex item that pinned every route to the full viewport, so each data page's `margin: 0 auto` centered its capped content in a full-width column instead of sitting at its natural width beside the sidebar. Toggle a `fill-viewport` class on #app for the Video route only, and restore the `min-width: 800px` the commit dropped from the Autopilot and Connections containers. Non-Video routes now render identically to before the commit; the Video route still gets the full-width frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the original layout of every data page (System, Autopilot, Connections, Services) while keeping the Video page full-width fix from 962f4f8.
Problem
962f4f8 fixed the Video page — which collapsed to a thin strip — by setting
width: 100%on#app. Because#appis mounted inside theindex.html#appcontainer it is a shrink-wrapping flex item, so pinning it to100%forced the full viewport width on every route. Each data page'smargin: 0 autothen centered its width-capped content in a full-width column instead of sitting at its natural width beside the sidebar.Solution
Scope the
width: 100%to the Video route only, via afill-viewportclass toggled by the active route, and restore themin-width: 800pxthe commit dropped from the Autopilot and Connections containers. Non-Video routes go back to shrink-wrapping#appto their own content, so they render as they did before the commit — the Autopilot and Connections files are byte-identical to their pre-commit state, and System/Services were never width-constrained by#app. On the Video route#appstill resolves todisplay: flex; width: 100%, so the frame keeps the full-width fix.