fix(setup): install binutils on the flash host#102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install binutils from
setup.sh, on the host side of the container re-exec. Minimal replacement for #101, which was reverted: its strict flash.sh check demanded NVIDIA's whole prerequisite list (python-is-python3 included) on hosts that have been flashing fine without it.Problem
NVIDIA's initrd-flash tooling uses
strings(binutils) to read the kernel version out of the built Image, with no upfront check — on a stock Ubuntu desktop install it fails mid-flash with a raw command-not-found. This is the one gap a customer actually hit; every other tool the flash needs has either been present in practice or is covered by NVIDIA's own sshpass/abootimg/zstd pre-check. setup.sh's existing apt install can't cover it because it sits after therun_in_containerre-exec, so on non-22.04 hosts it installs into the ephemeral build container and never touches the host.Solution
Add a binutils install in setup.sh's host-side section, before the container re-exec, guarded by
IN_BUILD_CONTAINERso the in-container pass skips it. No verification block in flash.sh.