Skip to content

dmicheck: Fix SMBIOS table size boundary check #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chetan-rathore merged 1 commit into from
Feb 27, 2026
Merged

dmicheck: Fix SMBIOS table size boundary check #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SystemReady-band/build-scripts/get_source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ get_buildroot_src()
exit 1
fi
pushd $TOP_DIR/buildroot/package/fwts
cp $TOP_DIR/patches/0001-dmicheck-fix-smbios-table-size-boundary-check.patch $TOP_DIR/buildroot/package/fwts
echo "Applying Buildroot FWTS patch..."
# patch buildroot config
git apply $TOP_DIR/../common/patches/build_fwts_version_${FWTS_VERSION}.patch
Expand Down
13 changes: 13 additions & 0 deletions SystemReady-band/patches/0001-dmicheck-fix-smbios-table-size-boundary-check.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index 1eab8360..621b0677 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -378,7 +378,7 @@ static int dmi_load_file_variable_size(
return FWTS_ERROR;

for (p = buf, total = count = 0; ; p += count) {
- if (total >= sz) {
+ if (total > sz) {
close(fd);
return FWTS_ERROR;
}