refactor(pal): Improve PAL not-implemented signalling and unify warnings#254
Merged
chetan-rathore merged 3 commits intoARM-software:mainfrom Feb 27, 2026
Merged
Conversation
- Introduce `pal_warn_not_implemented()` in every PAL environment (bare-metal,
UEFI ACPI, UEFI DT) and call it from each stub before returning
`PAL_STATUS_NOT_IMPLEMENTED`, so the PAL layer consistently emits a warning
with the API name.
- Replace the old macro-based status values with a `pal_status_t` enum, add
dedicated feature-status values, and keep compatibility helpers as macro.
- VAL now relies on the PAL warning while preserving existing skip/fail
behaviour in tests.
Signed-off-by: Rajat Goyal <rajat.goyal@arm.com>
Change-Id: I1fcfcbb23fd2aead4445aa4672a203eeb8da19ad
- Replace NOT_IMPLEMENTED checks with ACS_STATUS_PAL_NOT_IMPLEMENTED across test cases to align with updated PAL status definitions. - Convert RESULT_SKIP to RESULT_WARN where PAL interfaces are unimplemented - Introduce warn counters in RAS tests to distinguish warnings from functional failures Signed-off-by: Shanmuga Priya L <shanmuga.priyal@arm.com> Change-Id: I97618265d943ad5876859e2e96926baac873298b
- Replace NOT_IMPLEMENTED checks with ACS_STATUS_PAL_NOT_IMPLEMENTED across test cases to align with updated PAL status definitions. - Convert RESULT_SKIP to RESULT_WARN where PAL interfaces are unimplemented - Introduce warn counters in RAS tests to distinguish warnings from functional failures Signed-off-by: Shanmuga Priya L <shanmuga.priyal@arm.com> Change-Id: Ib3476ef1bd82584a4dd56a49a467dd7d738b2b92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pal_warn_not_implemented()in every PAL environment (bare-metal, UEFI ACPI, UEFI DT) and call it from each stub before returningPAL_STATUS_NOT_IMPLEMENTED, so the PAL layer consistently emits a warning with the API name.pal_status_tenum, add dedicated feature-status values and keep compatibility helpers as macro.Signed-off-by: Shanmuga Priya L shanmuga.priyal@arm.com