fix(unity-bootstrap-theme): improve hero small button positioning#1625
Open
juanmitriatti wants to merge 2 commits intodevfrom
Open
fix(unity-bootstrap-theme): improve hero small button positioning#1625juanmitriatti wants to merge 2 commits intodevfrom
juanmitriatti wants to merge 2 commits intodevfrom
Conversation
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1625/index.html |
davidornelas11
requested changes
Feb 10, 2026
- Change grid-template-rows from '0px 1fr 0px auto' to '0px 1fr auto auto' - Improves content spacing in hero small component
Contributor
Author
This is ready to review again. Thanks @davidornelas11 |
Contributor
Nice! Im gonna test it in webspark just to double check |
davidornelas11
approved these changes
Feb 18, 2026
Contributor
davidornelas11
left a comment
There was a problem hiding this comment.
Looks good in storybook now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Problem:
The
uds-hero-smcomponent uses absolute positioning for buttons, which causes overlap issues withheader content when text is long or on small screens. The fixed
top: 14.5remvalue doesn't adaptto different content sizes.
This issue is reported at : https://asudev.jira.com/browse/WS2-2385
Solution:
position: absolutetoposition: relativegrid-template-rows: 1fr auto auto $uds-size-spacing-7togrid-template-rows: 0px 1fr 0px autogrid-row: 4for proper grid placementmargin-top: 1remto.has-btn-row .btn-rowfor better spacingTesting Steps:
cd packages/unity-bootstrap-theme && yarn buildyarn storybookChecklist
Important Reminders
Links