Skip to content

fix(a11y): correct heading hierarchy in React components #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanmitriatti wants to merge 1 commit into
base: dev
Choose a base branch
from
+21 −7
Open

fix(a11y): correct heading hierarchy in React components #1634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/unity-bootstrap-theme/src/scss/extends/_anchor-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

h4, h2 {
font-size: 1rem;
line-height: 1.5rem;
letter-spacing: -0.015rem;
padding: 0 !important;

&:hover {
Expand Down
5 changes: 4 additions & 1 deletion packages/unity-bootstrap-theme/src/scss/extends/_images.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,12 @@
background: $uds-color-background-white 0% 0% no-repeat padding-box;
padding: 2rem;
font-size: $uds-size-font-medium;
h3, .h3 {
h2, h3, .h2, .h3 {
color: $asu-gray-1;
margin: 0 0 1rem 0;
font-size: $heading-three-font-size;
line-height: $heading-three-line-height;
letter-spacing: $heading-three-letter-spacing;
}
}
.uds-caption-text {
Expand Down
6 changes: 3 additions & 3 deletions packages/unity-react-core/src/components/AnchorMenu/AnchorMenu.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,13 @@ export const AnchorMenu = ({
data-bs-target="#collapseAnchorMenu"
aria-controls="collapseAnchorMenu"
>
<h4>
<h2>
{menuTitle}:<i className="fas fa-chevron-down" />
</h4>
</h2>
</button>
</GaEventWrapper>
) : (
<h4>{menuTitle}:</h4>
<h2>{menuTitle}:</h2>
)}

<div
Expand Down
2 changes: 1 addition & 1 deletion packages/unity-react-core/src/components/AnchorMenu/AnchorMenu.styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const AnchorMenuWrapper = styled.div`
background-color: transparent;
border: none;
cursor: default;
h4 {
h4, h2 {
align-items: center;
}
i {
Expand Down
2 changes: 1 addition & 1 deletion ...ty-react-core/src/components/ComponentCarousel/components/ImageCarousel/ImageCarousel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const htmlTemplate = ({ id, imageSource, imageAltText, title, content }) => ({
<div dangerouslySetInnerHTML={{ __html: content }} />
) : (
<>
<h3>{title}</h3>
<h2>{title}</h2>
{}
<div dangerouslySetInnerHTML={{ __html: content }} />
</>
Expand Down
2 changes: 1 addition & 1 deletion ...src/components/ComponentCarousel/components/ImageGalleryCarousel/ImageGalleryCarousel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ const CustomNavComponent = ({ instanceName, imageItems, hasContent }) => {
data-testid="image-gallery-content-container"
>
<div className="uds-caption-text">
{title ? <h3>{title}</h3> : null}
{title ? <h2>{title}</h2> : null}
{}
<div dangerouslySetInnerHTML={{ __html: content }} />
</div>
Expand Down
9 changes: 9 additions & 0 deletions ...core/src/components/ComponentCarousel/core/components/BaseCarousel/glide/glide.theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ $uds-breakpoint-sm: 576px;
$uds-breakpoint-lg: 1260px;
$asu-gray-1: #191919;
$uds-color-brand-gold: #ffc627; // ASU Gold brand color
$heading-three-font-size: 1.5rem;
$heading-three-line-height: 1.75rem;
$heading-three-letter-spacing: -0.0525rem;

@mixin shadow {
// At start, no "to right" in ::after rule
Expand Down Expand Up @@ -284,6 +287,12 @@ $uds-color-brand-gold: #ffc627; // ASU Gold brand color
figcaption {
padding: 0 0.75rem;
font-size: 0.75rem;

h2 {
font-size: $heading-three-font-size;
line-height: $heading-three-line-height;
letter-spacing: $heading-three-letter-spacing;
}
}

.image-navigator {
Expand Down