Skip to content

[Classic] Eastern kingdoms quest fixes + Trading post of april#2346

Merged
Eremeir merged 11 commits intoATTWoWAddon:masterfrom
milotic:master
Mar 30, 2026
Merged

[Classic] Eastern kingdoms quest fixes + Trading post of april#2346
Eremeir merged 11 commits intoATTWoWAddon:masterfrom
milotic:master

Conversation

@milotic
Copy link
Copy Markdown
Contributor

@milotic milotic commented Mar 11, 2026

No description provided.

@milotic milotic changed the title [Classic] Pamela Redpath's first quests are mutually exclusive. [Classic] Western plaguelands quest fixes Mar 11, 2026
@jewelking888
Copy link
Copy Markdown
Contributor

the pamela one is not true, they cross complete, so completing either means both are complete, its impossible to complete only one of them

@milotic
Copy link
Copy Markdown
Contributor Author

milotic commented Mar 11, 2026

@jewelking888 Thanks, corrected

@milotic milotic force-pushed the master branch 2 times, most recently from 6e4e6b3 to 0804cd7 Compare March 17, 2026 02:30
@NORPG NORPG requested a review from Exodius March 18, 2026 07:25
@milotic milotic changed the title [Classic] Western plaguelands quest fixes [Classic] Eastern kingdoms quest fixes Mar 18, 2026
@milotic milotic changed the title [Classic] Eastern kingdoms quest fixes [Classic] Eastern kingdoms quest fixes + Trading post of april Mar 30, 2026
}),
})),
n(MARCH, bubbleDownSelf({ ["timeline"] = { "added 12.0.1.66192", "removed 12.0.1.99999" } }, { -- TODO: Timeline out correctly
n(MARCH, bubbleDownSelf({ ["timeline"] = { "added 12.0.1.66192", "removed 12.0.1.66709" } }, {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeline out date is not set until the day of the new post in case new builds come out and so it's not prematurely removed.

@Eremeir
Copy link
Copy Markdown
Member

Eremeir commented Mar 30, 2026

We really shouldn't be reusing pull requests for different feature batches, but the post changes look good once those issues are addressed. Will reverify April 1st because Blizz does change things last minute and will set the build timeline then.

@milotic milotic force-pushed the master branch 2 times, most recently from 031d20c to 4bbcff8 Compare March 30, 2026 19:43
@milotic milotic requested a review from Eremeir March 30, 2026 19:44
@Exodius
Copy link
Copy Markdown
Member

Exodius commented Mar 30, 2026

We really shouldn't be reusing pull requests for different feature batches

I was gonna post the same thing as @Eremeir . In cases like this, it is better to create a different branch and open a separate PR.

the post changes look good once those issues are addressed. Will reverify April 1st because Blizz does change things last minute and will set the build timeline then.

On that note, I will let you merge the PR, @Eremeir
Stuff unrelated to the Trading Post looks OK to me.

@Eremeir Eremeir merged commit 4833bc9 into ATTWoWAddon:master Mar 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants