[Classic] Eastern kingdoms quest fixes + Trading post of april#2346
[Classic] Eastern kingdoms quest fixes + Trading post of april#2346Eremeir merged 11 commits intoATTWoWAddon:masterfrom
Conversation
|
the pamela one is not true, they cross complete, so completing either means both are complete, its impossible to complete only one of them |
|
@jewelking888 Thanks, corrected |
.contrib/Parser/DATAS/02 - Outdoor Zones/02 Eastern Kingdoms/Western Plaguelands.lua
Outdated
Show resolved
Hide resolved
6e4e6b3 to
0804cd7
Compare
| }), | ||
| })), | ||
| n(MARCH, bubbleDownSelf({ ["timeline"] = { "added 12.0.1.66192", "removed 12.0.1.99999" } }, { -- TODO: Timeline out correctly | ||
| n(MARCH, bubbleDownSelf({ ["timeline"] = { "added 12.0.1.66192", "removed 12.0.1.66709" } }, { |
There was a problem hiding this comment.
Timeline out date is not set until the day of the new post in case new builds come out and so it's not prematurely removed.
|
We really shouldn't be reusing pull requests for different feature batches, but the post changes look good once those issues are addressed. Will reverify April 1st because Blizz does change things last minute and will set the build timeline then. |
031d20c to
4bbcff8
Compare
I was gonna post the same thing as @Eremeir . In cases like this, it is better to create a different branch and open a separate PR.
On that note, I will let you merge the PR, @Eremeir |
No description provided.