Fix circuit-breaker false trips, upload path traversal, and HTML expo…#39
Merged
Merged
Conversation
ATaylorAerospace
commented
Jul 14, 2026
ATaylorAerospace
commented
Owner
- Loop detector signature now includes step metadata, so scoring many provisions no longer trips a spurious ReasoningLoopError; genuinely identical repeated steps still trip.
- Upload filenames are sanitized to their basename and resolved paths are validated to stay inside the session upload directory; size limit is now enforced even when the client omits Content-Length.
- Jinja autoescaping enabled for HTML report export so document-derived text cannot inject markup; also fixed section['items'] template lookup that crashed every HTML export.
- Added regression tests for all three fixes.
added 2 commits
July 14, 2026 17:21
…rt XSS - Loop detector signature now includes step metadata, so scoring many provisions no longer trips a spurious ReasoningLoopError; genuinely identical repeated steps still trip. - Upload filenames are sanitized to their basename and resolved paths are validated to stay inside the session upload directory; size limit is now enforced even when the client omits Content-Length. - Jinja autoescaping enabled for HTML report export so document-derived text cannot inject markup; also fixed section['items'] template lookup that crashed every HTML export. - Added regression tests for all three fixes.
CI installs only requirements.txt (the package itself is never installed), so test collection failed with ModuleNotFoundError on Python 3.11. Point pytest at the src layout explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.