Skip to content

fix(core): use URL encoding for path parameters#109

Open
mfabisiak wants to merge 7 commits into
masterfrom
fix/108-path-parameters-encoding
Open

fix(core): use URL encoding for path parameters#109
mfabisiak wants to merge 7 commits into
masterfrom
fix/108-path-parameters-encoding

Conversation

@mfabisiak

Copy link
Copy Markdown
Member

No description provided.

@mfabisiak mfabisiak self-assigned this Jul 24, 2026
Copilot AI review requested due to automatic review settings July 24, 2026 11:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

Coverage Report

Overall Project 96.98% -0.01% 🍏
Files changed 99.69% 🍏

File Coverage
Names.kt 100% 🍏
ApiClientBaseGenerator.kt 100% 🍏
ClientGenerator.kt 99.82% 🍏
ModelGenerator.kt 96.41% 🍏
BodyGenerator.kt 96.08% 🍏
Utils.kt 92.1% -0.61% 🍏

Copilot AI review requested due to automatic review settings July 24, 2026 12:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mfabisiak
mfabisiak marked this pull request as ready for review July 24, 2026 12:56

@MattK97 MattK97 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing: encodeParam now only works for primitives (jsonPrimitive throws on arrays/objects)- fine as-is, i'd just add a note in the code.

Copilot AI review requested due to automatic review settings July 24, 2026 16:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mfabisiak

Copy link
Copy Markdown
Member Author

LGTM, one thing: encodeParam now only works for primitives (jsonPrimitive throws on arrays/objects)- fine as-is, i'd just add a note in the code.

Now encodeParam only accepts primitives on type level - no runtime exceptions possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants