Add unit test for dics_coherence_external#14
Merged
Conversation
wmvanvliet
reviewed
Oct 8, 2025
| dics_coherence_external | ||
| ) | ||
| from conpy.connectivity import _BaseConnectivity, _get_vert_ind_from_label | ||
| from conpy.connectivity import BaseConnectivity, _get_vert_ind_from_label |
Collaborator
There was a problem hiding this comment.
I changed this as some point. _BaseConnectivity should be a private class.
wmvanvliet
reviewed
Oct 8, 2025
| @@ -382,7 +403,7 @@ def test_compatibility(): | |||
| # Test BaseConnectivity | |||
| assert not baseCon.is_compatible(label_con) | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| assert not baseCon.is_compatible(label_con) | |
| assert not con_base.is_compatible(label_con) |
The python convention is to use snake case 🐍 for variable names (and camel case for class names).
Collaborator
|
I've added CI robots that run the entire test suite. They are currently unhappy because of the |
Contributor
Author
|
The robots seem to be happy now |
Collaborator
|
very nice work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically as title says. It's not perfect, but 100% coverage except for the case of several external signals.
I was unable to run the entire test suite, but at least this test works on my machine.