Open
Conversation
Owner
|
That's a good idea, but I'm already maxed on block subtypes... Though I'm keeping the idea in mind! Maybe as an option disabled by default maybe? (I'll merge this PR once I start to work on this) |
Author
Sounds good. Especially since Rock Salt would be kind of useless unless you had another mod adding salt, considering there are other white rock types such as chalk (though I guess its pinkish colouring would be useful in some builds) |
|
Aang23 let me know if you want me to add rock salt |
|
PS: I learned how to comment in github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salt is a pretty common substance added by other mods. Usually, it is get by evaporating water, mining sand or as an ore. However, Halite isn't really a type of ore in the way iron or diamonds are. Thus, I though that adding Rock Salt as a type of Sedimentary rock to UBC would be great way to make UBC compatible with those mods that add salt, in a UBC way.
Note: This pull request only contains the textures for rock salt, as I'm not very experienced with adding blocks