Fixed compatibility with others mods, notably GTCEu#247
Open
LemADEC wants to merge 31 commits intoAang23:masterfrom
Open
Fixed compatibility with others mods, notably GTCEu#247LemADEC wants to merge 31 commits intoAang23:masterfrom
LemADEC wants to merge 31 commits intoAang23:masterfrom
Conversation
- improved memory usage related to biome checks - added stone brick replacement - added chiseled sandstone replacement - added half slab replacement - added double slab replacement - added wall replacement - fixed world object leaking - fixed structures not fully ubified - deadcode removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advanced mods actively use the target predicate in isReplaceableOreGen(). Since UBC ignores it and returns hardcoded values, this breaks compatibility with such mods like GTCEu.
This merge request address this by actually evaluating the predicate against vanilla equivalent block, allowing to integrate with other mods without having them to declare or support UBC variants.
When placing ore veins using a MutableBlockPos, UBC fails to ubify all ores due to invalid assumption on the permanent state of the passed object. This is clearly visible with GTCEu when only 1 ore per layer per vein is actually ubified.
This merge request fixes that issue with the related vanilla API.
A few deadcode locations have been cleaned up too.
I've made a GTCEu configuration file but I've no intention to reimplement it in the mod. Ping me if you want that file for your own modpack or would like to implement it in the mod, or whatnot.