Skip to content

Fix command injection in publish.js senso invocations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wd7zfpysvs-ui wants to merge 1 commit into from
Closed

Fix command injection in publish.js senso invocations #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { execSync } = require('child_process');
const { execFileSync } = require('child_process');

async function publishReceipt({ query, selectedResult, price, txHash, sourceUrl, searchResults }) {
const apiKey = process.env.SENSO_API_KEY;
Expand All @@ -10,20 +10,20 @@ async function publishReceipt({ query, selectedResult, price, txHash, sourceUrl,

// Create a Senso prompt tied to this purchase so we have a geo_question_id to publish against
const promptJson = senso(
`prompts create --data '${JSON.stringify({ question_text: questionText, type: 'decision' })}'`,
['prompts', 'create', '--data', JSON.stringify({ question_text: questionText, type: 'decision' })],
apiKey
);
const promptId = promptJson.prompt_id ?? promptJson.id;
if (!promptId) throw new Error('Senso prompt create did not return a prompt_id');

// Publish the receipt as a citeable on cited.md
const publishJson = senso(
`engine publish --data '${JSON.stringify({
['engine', 'publish', '--data', JSON.stringify({
geo_question_id: promptId,
raw_markdown: markdown,
seo_title: seoTitle,
summary: `Shop3 autonomously purchased ${selectedResult} for ${price}. Tx: ${txHash}`,
})}'`,
})],
apiKey
);

Expand All @@ -34,7 +34,7 @@ async function publishReceipt({ query, selectedResult, price, txHash, sourceUrl,

// Run a senso CLI command and return parsed JSON output
function senso(args, apiKey) {
const result = execSync(`senso ${args} --output json --quiet`, {
const result = execFileSync('senso', [...args, '--output', 'json', '--quiet'], {
env: { ...process.env, SENSO_API_KEY: apiKey },
encoding: 'utf8',
});
Expand Down
Loading