Open
Conversation
propertest file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thomas,
I fixed the project , so that it compiles again with current scala.
I fixed only errors, not warnings.
I also re-added tests, and disabled the ones that don't currently work.
I moved the whole project into maven.
I replaced all local libraries with proper maven-central libraries.
I added code in the maven pom file to deploy.
I removed one scala class because it's built-in scala now.
I bumped the library version to 1.2.0 to avoid confusion with the old library (which should functionally be almost identical)
I have deployed the new version to the ewi artifactory.