Merged
Conversation
Coverage report for library
Test suite run success453 tests passing in 22 suites. Report generated by 🧪jest coverage report action from d436c32 |
Playwright test resultsDetails
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on resolving accessibility gaps in the CPS radio components by ensuring radio groups/options have proper accessible naming, adding appropriate ARIA semantics, and strengthening automated a11y validation coverage.
Changes:
- Add
ariaLabelsupport and radiogroup semantics tocps-radio-group, including required/invalid/disabled ARIA states. - Ensure radio buttons are properly grouped via a generated shared
name, and add per-optionariaLabelsupport for cases with custom content. - Expand automated accessibility coverage (Playwright) to include the radio group and align a few related components’ ARIA error/required semantics.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/cps-ui-kit/src/lib/utils/internal/accessibility-utils.ts | Simplifies getComputedLabel to use a single error input for accessible label composition. |
| projects/cps-ui-kit/src/lib/components/cps-scheduler/cps-scheduler.component.html | Adds radio-group and option ariaLabels for scheduler frequency radios. |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio/cps-radio.component.html | Passes the generated group name down to rendered radio inputs. |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-group.component.ts | Introduces ariaLabel, generated groupName, required detection, and computed ARIA labeling. |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-group.component.spec.ts | Adds coverage for radiogroup aria-label behavior and unlabeled-group logging. |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-group.component.scss | Converts several px spacings to rem to improve scalability/zoom behavior. |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-group.component.html | Adds role="radiogroup" and key ARIA attributes; replaces ngClass with class bindings; makes errors assertively announced. |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-button/cps-radio-button.component.ts | Adds groupName input and unlabeled-option logging; tightens option usage. |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-button/cps-radio-button.component.scss | Improves focus-visible styling and disabled styling; introduces wrapper-based focus ring. |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-button/cps-radio-button.component.html | Applies shared name, sets per-option aria-label, and adds inert handling for non-selected content. |
| projects/cps-ui-kit/src/lib/components/cps-button/cps-button.component.spec.ts | Prevents console noise in a test that exercises unlabeled button rendering. |
| projects/cps-ui-kit/src/lib/components/cps-button-toggle/cps-button-toggle.component.ts | Marks component for check after font readiness sizing to keep layout in sync. |
| projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.ts | Adds required detection and adapts computed label to updated getComputedLabel signature. |
| projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.html | Announces errors via alert semantics and adds aria-required; normalizes aria-invalid to string. |
| projects/composition/src/app/pages/radio-page/radio-page.component.scss | Converts example page spacing from px to rem. |
| projects/composition/src/app/pages/radio-page/radio-page.component.html | Adds a vertical radio group example and ensures custom-content option has an ariaLabel. |
| projects/composition/src/app/api-data/cron-validation.service.json | Normalizes JSON line endings to LF. |
| projects/composition/src/app/api-data/cps-tree-table.json | Normalizes JSON line endings to LF. |
| projects/composition/src/app/api-data/cps-table.json | Normalizes JSON line endings to LF. |
| projects/composition/src/app/api-data/cps-radio-group.json | Updates generated API docs for new radio props/types (ariaLabel, groupName, ariaLabel on option). |
| projects/composition/src/app/api-data/cps-notification.json | Normalizes JSON line endings to LF. |
| playwright/cps-accessibility.spec.ts | Re-enables radio-group coverage in the Playwright accessibility suite. |
korel-san
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing accessibility issues in radio component
Validation rules:
Validated using Playwright accessibility tests, Lighthouse tool, axe DevTools extension, Accessibility Insights for Web extension, and manual checks including keyboard tab navigation and screen reader testing.
Full doc with rules
Playwright axe-core validation results:
State before:
State after:
Checklist
Keyboard Navigation
All interactive elements are fully operable via keyboard only, including buttons, inputs, menus, dialogs, sliders, drag-and-drop, tree views, multi-selects, and composite widgets. No traps or dead ends.
Focus Management
Focus is visible, logical, moves in predictable order, trapped where necessary (modals/popovers), and restored after closing. Focus is perceivable in all interactive widgets.
Semantics / ARIA
Color / Contrast
Screen Reader / Assistive Technology
Responsive & Zoom
Error Handling
Dynamic Content / Updates
Interaction Feedback / States
[N/A] Authentication & Sensitive Actions
Predictable & Controllable UI
Release notes: