fix: add test case for syncing PTR records#35
Open
BobVanB wants to merge 1 commit intoAbsaOSS:mainfrom
Open
Conversation
Contributor
Author
|
My colleague has made internal changes to ExternalDNS and the Infoblox webhook. He's currently on vacation, and when he returns, he will create a merge for this. The main change is that PTR records are now kept in sync, so it's no longer an issue for us if they disappear from Infoblox for some unknown reason. As far as I'm concerned, this pull request can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion: Responsibility for Restoring Missing PTR Records in Infoblox Webhook
Issue: Inconsistent Handling of PTR Record Restoration
Description of the Problem
We encountered an issue where missing PTR records in Infoblox are not automatically restored. This leads to inconsistencies where an A record exists, but its corresponding PTR record is absent.
Currently, we have observed two scenarios:
Stale PTR Records Exist
PTR Record is Missing
Root Cause
There is no clear ownership of PTR record restoration:
external-dnsdetect and recreate missing PTR records?Currently,
external-dnsprimarily manages A records, but there is an expectation that PTR records should be automatically restored when missing. However, without a clear decision on responsibility, this issue can lead to inconsistent DNS states.Proposed Next Steps
This PR introduces a test case to highlight the problem. Before implementing a fix, we need to decide:
external-dnsproactively restore missing PTR records?We request input from maintainers and users to determine the best approach.
Impact of This Change
Next Actions
external-dnsor the Infoblox webhook should handle missing PTR records.